🐝 (admin) disable slack message on DI creation / TAS-919 #4638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sophiamersmann
force-pushed
the
disable-di-pitches-slack
branch
from
f154124 to
1869ba8
Compare
|
Quick links (staging server):
Login:
SVG tester:Number of differences (default views): 0 ✅ Edited: 2025-03-06 16:05:54 UTC |
sophiamersmann
force-pushed
the
disable-di-pitches-slack
branch
from
1869ba8 to
8dc85cf
Compare
sophiamersmann
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't send newly created DIs to the #data-insights-pitches Slack channel. Basically reverts #4571 (can't use GitHub's automatic revert feature for some reason).
We might bring this feature back but I don't think it's likely we'll do so soon, so I deleted the code rather than commenting out or using a feature flag. I left the api route that sends messages to Slack in – seems like useful infrastructure, but if you prefer I can also delete that.